On Thu, May 16, 2013 at 04:00:53PM -0700, Sriraman Tallam wrote: > On Thu, May 16, 2013 at 3:55 PM, Marc Glisse <marc.gli...@inria.fr> wrote: > > I don't really understand why you made the change to x86intrin.h instead of > > making it inside each *mmintrin.h header. The code would be the same size, > > it would let us include smmintrin.h directly if we wanted to, and > > x86intrin.h would also automatically work. > > Right, I should have done that instead!
Yeah, definitely. For the standalone headers, which have currently __<FEATURE>__ guards inside of it, please replace it by the larger snippets involving #pragma, and in the x86intrin.h/immintrin.h headers include those unconditionally, instead of just if __<FEATURE>__ is defined. For the non-standalone headers (newer ones like avxintrin.h), replace the #ifdef __<FEATURE>__ in immintrin.h/x86intrin.h with larger snippets. Jakub