On Fri, 10 May 2013, Sriraman Tallam wrote: > On Fri, May 10, 2013 at 6:34 AM, Joseph S. Myers > <jos...@codesourcery.com> wrote: > > On Thu, 9 May 2013, Sriraman Tallam wrote: > > > >> Then, I plan to add the following hooks to libgcc (in a different patch) : > >> > >> int set_mock_cpu_is (const char *cpu); > >> int set_mock_cpu_supports (const char *isa); > >> int init_mock_cpu (); // Clear the values of the mock cpu. > > > > Those names are in the user's namespace; I think libgcc should only > > provide or use symbols in the implementation namespace. > > Shall I just use __builtin prefixes for these too?, would that work?
I'm not sure if that's a good idea for something that's actually a library function (we've previously discussed rejecting explicit declarations of __builtin_* identifiers to some extent - see bug 32455 - which would be an issue for defining library functions with such a name if we do decide in future to reject such declarations), but use __ prefixes in some form, certainly. -- Joseph S. Myers jos...@codesourcery.com
