On Thu, May 9, 2013 at 8:19 PM, Alan Modra <amo...@gmail.com> wrote:
> On Thu, May 09, 2013 at 01:33:59PM -0500, Edmar Wienskoski wrote:
>> On Thu, May 9, 2013 at 2:27 AM, Alan Modra <amo...@gmail.com> wrote:
>> > Another tweak for little-endian powerpc.  Committed revision 198734.
>> >
>> >         * configure.ac (HAVE_AS_TLS): Enable tests for powerpcle and
>> >         powerpc64le.
>> >         * configure: Regenerate.
>
>> The first hunk will match powerpc64 as well.
>
> Thanks for pointing this out.  My powerpc64 testing didn't catch
> this because the powerpc test also passes for powerpc64.  In fact
> there really isn't any need for the powerpc64 variant test, except
> perhaps to support someone who has messed with gas to disable 32-bit
> support (which you can't do via configure options, at least nowadays).
> Powerpc 32-bit and 64-bit TLS support were added to gas at the same
> time.
>
> So even though the powerpc64 case could disappear, I think it simplest
> to just move the two cases around.  I also have another tweak to run
> by David regarding HAVE_LD_LARGE_TOC.  A linux build gets "Define if
> your AIX linker..." in the auto-host.h comment, from the AC_DEFINE
> David added recently for AIX -mcmodel support.  That's a little
> confusing, so I propose changing the text to remove mention of the
> operating system.  OK?
>
>         * configure.ac (HAVE_AS_TLS): Swap powerpc64 and powerpc cases.
>         (HAVE_LD_LARGE_TOC): Don't mention AIX in help text.
>         * configure: Regenerate.

Okay.

Thanks, David

Reply via email to