On Mon, 2013-05-06 at 17:28 -0700, H.J. Lu wrote: > On Mon, May 6, 2013 at 12:29 PM, Bill Schmidt > <wschm...@linux.vnet.ibm.com> wrote: > > On Mon, 2013-05-06 at 21:25 +0200, Jakub Jelinek wrote: > >> On Sun, May 05, 2013 at 03:45:17PM -0500, Bill Schmidt wrote: > >> > 2013-05-05 Bill Schmidt <wschm...@linux.vnet.ibm.com> > >> > > >> > * gimple-ssa-strength-reduction.c (slsr_process_phi): Re-enable. > >> > (find_candidates_in_block): Re-enable slsr_process_phi. > >> > (create_phi_basis): Fix double counting of candidate adjustment. > >> > >> This broke gcc.dg/pr33017.c testcase on i?86/x86_64 -m32. > >> ./cc1 -O2 -ftree-vectorize -m32 -mno-sse pr33017.c > > > > Jakub, thanks, I'll take a look. > > > > Bill > > > >> difference between r19862{6,7} is: > >> --- pr33017.s1 2013-05-06 21:22:03.786745422 +0200 > >> +++ pr33017.s2 2013-05-06 21:22:16.844673015 +0200 > >> @@ -32,9 +32,9 @@ foo: > >> movb $87, var.1373+2(%eax) > >> je .L10 > >> cmpl $3, %edx > >> - movb $87, var.1373+3(%eax) > >> + movb $87, var.1373+2(%eax,%eax) > >> jne .L11 > >> - movb $87, var.1373+4(%eax) > >> + movb $87, var.1373+2(%eax,%eax,2) > >> movl $3, %ebp > >> movl $61, 28(%esp) > >> .L3: > >> > >> Jakub > >> > > > > > > It also caused: > > > AIL: gcc.dg/vect/vect-28.c -flto execution test > FAIL: gcc.dg/vect/vect-28.c execution test > FAIL: gfortran.dg/array_constructor_9.f90 -O3 -fomit-frame-pointer > execution test > FAIL: gfortran.dg/array_constructor_9.f90 -O3 -fomit-frame-pointer > -funroll-all-loops -finline-functions execution test > FAIL: gfortran.dg/array_constructor_9.f90 -O3 -fomit-frame-pointer > -funroll-loops execution test > FAIL: gfortran.dg/array_constructor_9.f90 -O3 -g execution test > FAIL: gfortran.dg/char_result_3.f90 -O3 -fomit-frame-pointer execution test > FAIL: gfortran.dg/char_result_3.f90 -O3 -fomit-frame-pointer > -funroll-all-loops -finline-functions execution test > FAIL: gfortran.dg/char_result_3.f90 -O3 -fomit-frame-pointer > -funroll-loops execution test > FAIL: gfortran.dg/char_result_3.f90 -O3 -g execution test > FAIL: gfortran.dg/cray_pointers_2.f90 -O execution test > FAIL: gfortran.dg/realloc_on_assign_2.f03 -O3 -fomit-frame-pointer > execution test > FAIL: gfortran.dg/realloc_on_assign_2.f03 -O3 -fomit-frame-pointer > -funroll-all-loops -finline-functions execution test > FAIL: gfortran.dg/realloc_on_assign_2.f03 -O3 -fomit-frame-pointer > -funroll-loops execution test > FAIL: gfortran.dg/realloc_on_assign_2.f03 -O3 -g execution test > > on i686. > > -- > H.J. >
H.J., do you know whether the proposed patch fixes these failures? I'll take a look at these tomorrow if not. Thanks, Bill