On 30/04/13 17:53, Kyrylo Tkachov wrote:
-----Original Message-----
From: Ramana Radhakrishnan
Sent: 03 April 2013 16:16
To: Kyrylo Tkachov
Cc: GCC Patches
Subject: Re: [PATCH][ARM] Fix PR 56809
On 04/03/13 16:07, Kyrylo Tkachov wrote:
Hi all,
This patch fixes an ICE that we encounter when building gcc on arm
targets.
The jump table reorganisation exposed a bug in the backend.
This fixes it
by using next_active_insn instead of next_real_insn when looking for
the
diff vector in the jump table handling code. (Thanks to Steven
Bosscher for
the tip).
A separate aarch64 patch is coming soon separately.
Tested arm-none-eabi on qemu and confirmed that the build for
arm-none-linux-gnueabi is fixed.
Since the PR affects both arm and aarch64 I put a testcase into
gcc.dg.
Ok for trunk?
Ok for trunk.
Given that this fixes a latent bug, is it ok to backport to 4.8 and 4.7?
Tested the patch on those branches with no regressions on arm-none-eabi.
I don't really see the point. Firstly, the bug can't happen on those
branches unless Stephen's code is back-ported. Secondly, there's still
some debate about the change he made. See the recent discussion on MIPS.
What's your reasoning for doing a back-port?
R.
