On Thu, 18 Apr 2013, Chung-Lin Tang wrote: > 2013-04-18 Chung-Lin Tang <clt...@codesourcery.com> > > * opts-common.c (integral_argument): Add support for hexadecimal > command option integer arguments. Update comments.
You should propose this sort of non-Nios II-specific change in a separate thread with its own rationale for the change. > + /* It wasn't a decimal number - try hexadecimal. */ > + if (arg[0]=='0' && (arg[1]=='x' || arg[1]=='X')) Spacing around "==". I think you do need to check all the characters here as is done for decimal arguments (but using ISXDIGIT), in order to ensure that no locale-specific form is accepted by strtol. -- Joseph S. Myers jos...@codesourcery.com
