On 3 April 2013 12:59, Paolo Carlini wrote: > On 04/03/2013 01:53 PM, Jonathan Wakely wrote: >> >> On 3 April 2013 12:45, Paolo Carlini wrote: >>> >>> On 04/03/2013 02:09 AM, Jonathan Wakely wrote: >>>> >>>> This patch implements >>>> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2010/n3189.htm >>> >>> Thanks Jon. I'm seeing abi_check fails which seem related. Could you >>> please >>> double check? >> >> Ah sorry, I didn't commit the change to add GLIBCXX_3.4.19 to the >> known_versions. I'll do that later today. > > Yeah, but I'm afraid isn't enough. Thanks for looking into it.
This fixes the abi check for me. * testsuite/util/testsuite_abi.cc: Add GLIBCXX_3.4.19 version. Tested x86_64-linux, committed to trunk.
commit bb12b552f04f260c44a93f196604cb3c51a1b12f Author: Jonathan Wakely <jwakely....@gmail.com> Date: Thu Apr 4 09:42:27 2013 +0100 * testsuite/util/testsuite_abi.cc: Add GLIBCXX_3.4.19 version. diff --git a/libstdc++-v3/testsuite/util/testsuite_abi.cc b/libstdc++-v3/testsuite/util/testsuite_abi.cc index c9de9c8..67f260d 100644 --- a/libstdc++-v3/testsuite/util/testsuite_abi.cc +++ b/libstdc++-v3/testsuite/util/testsuite_abi.cc @@ -195,6 +195,7 @@ check_version(symbol& test, bool added) known_versions.push_back("GLIBCXX_3.4.16"); known_versions.push_back("GLIBCXX_3.4.17"); known_versions.push_back("GLIBCXX_3.4.18"); + known_versions.push_back("GLIBCXX_3.4.19"); known_versions.push_back("GLIBCXX_LDBL_3.4"); known_versions.push_back("GLIBCXX_LDBL_3.4.7"); known_versions.push_back("GLIBCXX_LDBL_3.4.10"); @@ -223,7 +224,7 @@ check_version(symbol& test, bool added) test.version_status = symbol::incompatible; // Check that added symbols are added in the latest pre-release version. - bool latestp = (test.version_name == "GLIBCXX_3.4.18" + bool latestp = (test.version_name == "GLIBCXX_3.4.19" || test.version_name == "CXXABI_1.3.7" || test.version_name == "CXXABI_TM_1"); if (added && !latestp)