> >> The use of TAB there is fine. The issue is that you have trail > white > >> space at the end of the line, which is still present in the latest > patch. > > Sorry. I confused it with spaces at the start of pattern instead of > trailing space. I have modified it as per your suggestion. > Please review the modified patch.
Hi Naveen, It looks like you didn't quite catch all of them: > +#define DEF3a(fname, type, op) \ > + void fname##_##type (pR##type a, \ > + pR##type b, \ > + pR##type c) \ > + { \ > + int i; \ > + for (i = 0; i < 16; i++) \<!tab!> > + a[i] = op (b[i] - c[i]); \ > + } This one introduces a problem for the testsuite as whitespace between a \ and the newline is an error on some compilers and a warning on GCC. There is a script at contrib/check_GNU_style.sh which is helpful for catching bugs like this. Thanks, James Greenhalgh