Paul Richard Thomas wrote:
It looks OK to me - is Jakub OK with it?
On 8 February 2013 21:48, Thomas Koenig <tkoe...@netcologne.de> wrote:
the attached patch fixes the PR by (re-)adding a search path
for the path used by intrinsic modules.
Regression-tested. OK for trunk?
I am still recovering from a cold, but I have some questions:
Are you sure that the test case in gfortran.dg/gomp/omp_lib_1.F works?
The OpenMP Fortran headers (and modules) are generated in libgomp/.
Thus, I am not sure they are available in gcc/testsuite/gfortran.dg/gomp
(in particular when the compiler is not installed).
+ /* FIXME: This is needed because omp_lib.h is in a
+ directory together with intrinsic modules. */
+ gfc_add_include_path (arg, false, false);
+
Why did you put a FIXME there? What's wrong with adding the directory here?
And, as you re-add the "gfc_add_include_path", which you have removed in
http://gcc.gnu.org/ml/fortran/2012-08/msg00013.html - What has changed
to avoid the issues which lead to the patch in August patch, namely
"Seems to break testing, all testcases emit
Warning: Nonexistent include directory "finclude"^M"
I think those only occurred when the compiler is not installed. Will
they pop up again?
Tobias
2013-02-08 Thomas Koenig <tkoe...@gcc.gnu.org>
PR fortran/56224
* options.c (gfc_handle_option): Also call
gfc_add_include_path for intrinsic modules.
2013-02-08 Thomas Koenig <tkoe...@gcc.gnu.org>
PR fortran/56224
* gfortran.dg/gomp/omp_lib_1.F: New test.
* gfortran.dg/gomp/omp_lib_2.f: New test.
