On 01/28/13 14:03, amol pise wrote:
Dear Ramana,
Thank You very much for the changelog and commit of my patch in gcc.
I will follow the steps mentioned by you.
There are no vector forms for the vfnma and vfnms instructions.
A co-worker (thanks Kyryll) just pointed out to me that I'd misread the
ARM-ARM when I checked this and it looks like the test run I did had
failed but it looks I looked I checked the wrong work area.
Looking at the output a bit more carefully now compared to what I did
the other day I see only the scalar forms being generated.
Also the ARM-ARM specifies that these instructions only have the scalar
forms (Section 8.8.318)
vfnm<>.f64 Dd, Dn, Dm
vfnm<>.f32 Sd, Sn, Sm
instructions.
I have now reverted this patch as obvious.
Sorry about the inconvenience caused.
regards
Ramana
Thank You,
Amol Pise
On Mon, Jan 28, 2013 at 4:18 PM, Ramana Radhakrishnan <ramra...@arm.com> wrote:
[Taking gcc-help off this thread.]
Amol,
I have tested these instruction with GCC and these instructions are
generated.
Please review and marge this test support patch in gcc main trunk.
Thanks for this patch and sorry about the delay in getting around to this.
This is ok and I'll take this under the 10 line rule this time .
If you intend to continue to submit patches to gcc can I ask that you start
the process for copyright assignments or confirm that you have a copyright
assignment on file ?
http://gcc.gnu.org/contribute.html#legal
If you don't, send an email to g...@gcc.gnu.org with a request for copyright
assignment papers and a maintainer will send you these.
http://gcc.gnu.org/contribute.html in general is a good summary of the
process related to contributing patches to GCC in general . Please do read
that and follow up on g...@gcc.gnu.org if you have any more questions.
And finally don't forget to add a changelog to your patches as documented in
links from the above mentioned page. Since this is your first time I've
added the following Changelog entry for your patch and applied it.
regards
Ramana
2013-01-27 Amol Pise <amolpis...@gmail.com>
* gcc.target/arm/neon-vfnms-1.c: New test.
* gcc.target/arm/neon-vfnma-1.c: New test.
