LGTM

https://codereview.appspot.com/7130047/diff/1/gcc/go/gospec.c
File gcc/go/gospec.c (right):

https://codereview.appspot.com/7130047/diff/1/gcc/go/gospec.c#newcode230
gcc/go/gospec.c:230: num_args = argc + need_math + shared_libgcc +
(library > 0) * 5 + 5;
I wonder if we should change + 5 to + 10.

https://codereview.appspot.com/7130047/diff/1/gcc/go/gospec.c#newcode388
gcc/go/gospec.c:388: the linker */
Missing period at end of sentence.  Also, two spaces after period after
"non-weak."  Comment should wrap around line 75 or so in GCC code.

https://codereview.appspot.com/7130047/diff/1/gcc/go/gospec.c#newcode391
gcc/go/gospec.c:391: &new_decoded_options[j++]);
Put j++ on a separate line.

https://codereview.appspot.com/7130047/

Reply via email to