On 15/01/2013, at 4:55 AM, Alexander Ivchenko wrote:
> thank you very much for your review!
>
> I fixed the arm build and all other issues that you raised.
>
> the patch is attached. Bootstrap and tested on x86-64 linux
The patch is OK with the cleanups mentioned below (no need to resubmit for
review). Unfortunately, you will have to wait for Stage 1 to commit your patch.
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -636,6 +636,11 @@ case ${target} in
> native_system_header_dir=/include
> ;;
> esac
> + case $target in
> + *linux*)
> + tm_p_file="${tm_p_file} linux-protos.h"
> + ;;
> + esac
> # glibc / uclibc / bionic switch.
> # uclibc and bionic aren't usable for GNU/Hurd and neither for GNU/k*BSD.
> case $target in
Can we merge this above hunk into subsequent "case $target" statement ...
> @@ -661,8 +666,10 @@ case ${target} in
> # Add Android userspace support to Linux targets.
> case $target in
> *linux*)
> + tmake_file="${tmake_file} t-linux-android"
> tm_file="$tm_file linux-android.h"
> extra_options="$extra_options linux-android.opt"
> + extra_objs="$extra_objs linux-android.o"
> ;;
> esac
... here?
> # Enable compilation for Android by default for *android* targets.
> @@ -863,7 +870,9 @@ arm*-*-netbsdelf*)
> tmake_file="${tmake_file} arm/t-arm"
> ;;
> arm*-*-linux-*) # ARM GNU/Linux with ELF
> + tmake_file="${tmake_file} t-linux-android"
Merge this with tmake_file= setting a couple of lines down. Put
t-linux-android last on the line.
> tm_file="dbxelf.h elfos.h gnu-user.h linux.h linux-android.h
> glibc-stdint.h arm/elf.h arm/linux-gas.h arm/linux-elf.h"
> + extra_objs="$extra_objs linux-android.o"
Please push extra_objs= setting a couple of lines down so that addition of
t-linux-android and linux-android.o are side-by-side.
> case $target in
> arm*b-*-linux*)
> tm_defines="${tm_defines} TARGET_BIG_ENDIAN_DEFAULT=1"
> diff --git a/gcc/config/linux-android.c b/gcc/config/linux-android.c
> new file mode 100644
> index 0000000..f3d82a5
> --- /dev/null
> +++ b/gcc/config/linux-android.c
> @@ -0,0 +1,34 @@
> +/* Functions for Linux Android as target machine for GNU C compiler.
> + Copyright (C) 2001, 2002, 2003, 2004, 2005, 2007, 2008, 2010, 2011,
> + 2012, 2013.
Should be "Copyright (C) 2013." The copyright dates start with the year in
which a file was added.
Also, for any file that your changes touch please add 2013 to the list of
copyright years. This is an annoying chore that committers have to do at the
beginning of each year.
> diff --git a/gcc/config/linux-protos.h b/gcc/config/linux-protos.h
> new file mode 100644
> index 0000000..aae1d28
> --- /dev/null
> +++ b/gcc/config/linux-protos.h
> @@ -0,0 +1,22 @@
> +/* Prototypes.
> + Copyright (C) 2001, 2002, 2003, 2004, 2005, 2007, 2008, 2010, 2011,
> + 2012, 2013
"Copyright (C) 2013."
> --- /dev/null
> +++ b/gcc/config/t-linux-android
> @@ -0,0 +1,23 @@
> +# Copyright (C) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011,
> 2013
"Copyright (C) 2013."
Thanks!
--
Maxim Kuvyrkov
