On Mon, 7 Jan 2013, Richard Sandiford wrote: > "Joseph S. Myers" <jos...@codesourcery.com> writes: > > On Sun, 6 Jan 2013, Richard Sandiford wrote: > > > >> Anyway, here's my attempt a script to convert to ranges and, if enabled, > >> to include the current year. The script only updates FSF copyright notices > >> and leaves others alone. I've tried my best to make sure that licences > >> and imported FSF sources aren't touched, but I could have missed some > >> cases. > > > > I don't see anything to exclude the soft-fp files imported from glibc > > (where the current glibc versions should be copied instead ... but note > > that some soft-fp files, e.g. for TImode, are GCC-specific and not in > > glibc). > > Hmm, OK. Is there a plan to move those to glibc? Every file seems to say > "This file is part of the GNU C Library.", but it wasn't obvious whether > that was an aspiration or just cut-&-paste.
They'd only move to glibc if some architecture has a use for them (most likely if some architecture wishes to support rounding modes and exceptions for soft-float, like powerpc, but also has TImode support; in that case the best results would come from that architecture using these functions only in glibc and not in libgcc at all). > Maybe it'd be easier for the script to treat them all as imported and > soft-fp altogether. Would that be OK? Sure. The point should be to get something in that covers a useful set of files, and then its coverage can be expanded incrementally later. > OK, hadn't expected it to be that complicated, but there again, I wasn't > sure if we'd ever use the --shared flag anyway. It was there as much to > differentiate the "shared with src" cases from the "imported from upstream" > cases. I didn't look at what options might cause the script to touch what directories, just for cases that appeared like they might be covered but that have complications. > > I think a patch for each directory will need posting separately for review > > of such things as whether any imported / generated files are mistakenly > > changed. > > So fixincludes/ separate from gcc/, and every library separate? OK. Yes, I think that will produce sensibly-sized chunks for people familiar with the relevant directories to review to see whether any imported files are being inappropriately changed, generated files changed without corresponding changes to their sources, or sources for generated files changed without corresponding changes to the generated files. -- Joseph S. Myers jos...@codesourcery.com
