Dear Tobias, It looks good to me. OK for trunk
Thanks for the patch - we'll have regressions down below 20 by tonight. I am rather certain that I have the correct fix for PR55618. Let's see if we can get to single figures, once more, by the end of the month! Paul On 7 January 2013 10:13, Tobias Burnus <bur...@net-b.de> wrote: > Dear all, > > the following patch is based on Thomas' comment 5 in PR55852. He > independently created a patch for the PR; his version is in comment 6: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55852#c6 > > > The problem with the current trunk's version of gfc_build_intrinsic_call is > that it assumes that gfc_find_symtree will return the intrinsic function > ("size" in this case); if the user has a different symbol named "size" or > hasn't used "size", the code doesn't work. > > > My version is attached. > > In my version, the gfc_build_intrinsic_call takes "gfc_isym_id" as > identifier for the intrinsic - the passed string is mangled via GFC_PREFIX > to avoid issues with symbol declarations of the user. > > I do set rather bluntly "n.sym... = ", assuming that under mangled name one > always finds this intrinsic function. > > Besides fixing the ICE, I used the opportunity to cleanup class.c, where I > now use gfc_build_intrinsic_call, which is a nice cleanup: 4 files changed, > 65 insertions(+), 143 deletions(-) > > > Build and regtested on x86-64-gnu-linux. > OK for the trunk? > > Tobias -- The knack of flying is learning how to throw yourself at the ground and miss. --Hitchhikers Guide to the Galaxy
