The code looks fine to me. Please consider David's comments about the option name.
-Rong On Thu, Jan 3, 2013 at 9:14 PM, Xinliang David Li <davi...@google.com> wrote: > Is it better to change the option to something like: > > split_segment|nosplit-segment > or split_segment=yes|no > > > David > > On Thu, Jan 3, 2013 at 5:41 PM, Sriraman Tallam <tmsri...@google.com> wrote: >> Hi Rong, >> >> The following patch modifies the behaviour of the linker plugin to >> not create a separate segment for cold sections by default. Separate >> segments can be created with the plugin option "segment=cold". Is this >> alright to commit? >> >> Thanks, >> -Sri. >> >> On Mon, Dec 17, 2012 at 11:14 AM, Sriraman Tallam <tmsri...@google.com> >> wrote: >>> I have committed this patch. >>> >>> Thanks, >>> -Sri. >>> >>> On Fri, Dec 14, 2012 at 4:16 PM, Rong Xu <x...@google.com> wrote: >>>> Looks good to me for google/gcc-4_7 branch. >>>> >>>> Thanks, >>>> >>>> -Rong >>>> >>>> >>>> On Fri, Dec 14, 2012 at 3:42 PM, Sriraman Tallam <tmsri...@google.com> >>>> wrote: >>>>> >>>>> Hi Rong, >>>>> >>>>> Please review this code. This code allows the function reordering >>>>> plugin to separate hot and cold code into different ELF segments. >>>>> This would allow optimizations like mapping the hot code alone to huge >>>>> pages. >>>>> >>>>> With this patch, by default, the plugin maps .text.unlikely >>>>> sections into a separate ELF segment. This can be turned off with >>>>> plugin option "--segment=none". >>>>> >>>>> The include/plugin-api.h changes are a backport from trunk. >>>>> >>>>> Thanks, >>>>> -Sri. >>>> >>>>
