"H.J. Lu" <hjl.to...@gmail.com> writes: > On Thu, Jan 3, 2013 at 10:09 AM, Andreas Schwab <sch...@linux-m68k.org> wrote: >> "H.J. Lu" <hjl.to...@gmail.com> writes: >> >>> diff --git a/libjava/Makefile.am b/libjava/Makefile.am >>> index c6c84e4..dd08a4f 100644 >>> --- a/libjava/Makefile.am >>> +++ b/libjava/Makefile.am >>> @@ -594,7 +594,7 @@ lib_gnu_awt_xlib_la_CPPFLAGS = \ >>> $(AM_CPPFLAGS) \ >>> $(LIBSTDCXX_RAW_CXX_CXXFLAGS) >>> ## The mysterious backslash in the grep pattern is consumed by make. >>> -lib_gnu_awt_xlib_la_LDFLAGS = $(LIBSTDCXX_RAW_CXX_LDLAGS) \ >>> +lib_gnu_awt_xlib_la_LDFLAGS = $(LIBSTDCXX_RAW_CXX_LIBADD) \ >>> @X_PRE_LIBS@ @X_LIBS@ -lX11 @X_EXTRA_LIBS@ \ >>> -rpath $(toolexeclibdir) $(LIBJAVA_LDFLAGS_NOUNDEF) \ >>> -version-info `grep -v '^\#' $(srcdir)/libtool-version` >>> $(LIBGCJ_LD_SYMBOLIC) >> >> It is still wrong to use LDFLAGS for libraries to be linked in. >> All of $(LIBSTDCXX_RAW_CXX_LIBADD) @X_PRE_LIBS@ @X_LIBS@ -lX11 >> @X_EXTRA_LIBS@ should be on lib_gnu_awt_xlib_la_LDADD. >> > > This was how it was done before my change. If we want to > make a change, I can submit a separate patch.
Libraries should never occur before the objects which reference them. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
