On Fri, 2012-12-21 at 15:15 +0100, Jakub Jelinek wrote:
> Hi!
> 
> Peter reported on IRC that many asan tests are failing on ppc, apparently
> lots of that is related to -fsection-anchors decls and STRING_CSTs, which
> weren't considered before.
> 
> This patch attempts to fix all the issues I saw on the few testcases.
> Bootstrapped/regtested on x86_64-linux and i686-linux and eyeballed
> global-overflow-1.c and some other small testcase with a -> powerpc64-linux
> cross-compiler.  Ok for trunk?
> 
> 2012-12-21  Jakub Jelinek  <ja...@redhat.com>
> 
>       * varasm.c (output_constant_def_contents): For asan_protect_global
>       protected strings, adjust DECL_ALIGN if needed, before testing for
>       anchored symbols.
>       (place_block_symbol): Adjust size for asan protected STRING_CSTs if
>       TREE_CONSTANT_POOL_ADDRESS_P.  Increase alignment for asan protected
>       normal decls.
>       (output_object_block): For asan protected decls, emit asan padding
>       after their contents.
>       (asan_protect_global): Don't check TREE_ASM_WRITTEN here.
>       (asan_finish_file): Test it here instead.

FYI, this bootstrapped/regtested with no errors on powerpc64-linux and
fixes many of failures with the new asan test cases on powerpc*-linux.
Thanks Jakub!

Peter



Reply via email to