On Mon, Dec 3, 2012 at 3:05 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Mon, Dec 03, 2012 at 01:51:50PM +0400, Konstantin Serebryany wrote: >> > I'm attaching the diff for asan_test.cc from llvm anyway. >> > >> >> I see #ifdef ASAN_AVOID_EXPENSIVE_TESTS, which I don't really like >> >> because I'd rather fix the test than disable it. >> > >> > The test isn't disabled, just by default limited to 30 threads instead of >> > 1000, because that really will ruin testing for everybody with ulimit -u >> > in 1024-ish range. Even 500 threads would be undesirable for that. >> >> Which is the same as disabling it. >> Unfortunately, we don't have a good automated way to test asan performance, >> so this test is guarding us from performance degradation in the asan's >> pthread wrappers. > > I understand that, that is why the test by default, when not run as part of > dejagnu, or even in dejagnu when requested expensive tests, runs 1000 > threads instead of 30. > >> Anyway, does http://llvm.org/viewvc/llvm-project?rev=169118&view=rev >> solve the problem? >> It adds ASAN_AVOID_EXPENSIVE_TESTS and checks the results of all >> pthread_{create,join} calls in tests. > > Yes, thanks. So, is the patch ok to commit to GCC with the imported tests > remerged > from upstream
Yes, ok to commit. Thanks! --kcc > (or do I need to repost the patch for that)? > > Jakub
