Looks good. On Fri, Nov 23, 2012 at 3:27 PM, Tobias Burnus <bur...@net-b.de> wrote: > Konstantin Serebryany wrote: >> >> On Mon, Nov 19, 2012 at 10:44 PM, Tobias Burnus <bur...@net-b.de> wrote: >>> >>> attached is a first draft for -faddress-sanitizer in the release notes. >> >> stack overflow is something different, I guess we want to say "stack >> >> buffer overflow". I typically write something like "heap-, stack-, and >> global- buffer >> overflow as well as use-after-free bugs". > > > Fixed. See attached updated patch. > > >> I also suggest adding "use -O1 or higher for better performance" >> because otherwise "fast memory error detector" is not really true. > > > Is that needed? I think that's obvious that -O0 is not that fast.
asan at O0 is *really* slow, and for some users it may be non-obvious. but I don't insist because your patch give the links to the detailed docs. > > > Notes: I didn't mention Sparc, PowerPC, and Darwin Darwin works fine with clang, but not yet in gcc. > as those aren't yet > available. I kept the current wording for ASAN even though global and stack > overflow are to my knowledge not yet available. at least simple tests for stack- and global- buffer overflows seem to work. Thanks! --kcc > > Tobias
