From: Richard Henderson <r...@redhat.com> Date: Mon, 12 Nov 2012 09:56:21 -0800
> On 10/22/2012 08:39 PM, David Miller wrote: >> + /* Compare and Branch is limited to +-2KB. If it is too far away, >> + change >> + >> + cxbne X, Y, .LC30 >> + >> + to >> + >> + cxbe X, Y, .+12 >> + ba,pt xcc, .LC30 >> + nop */ > > Based on your no-control-after cbcond comment at the top > of the patch, surely this should contain another nop as well. Indeed, I'll fix this up. > And surely all this code isn't so performance sensitive that > it needs to be written in such an unreadable way. Sure, I'll change the code to use one of the the clearer mechanisms you suggested. Thanks for the review.
