Hi, I don't insist that we use gtest for gcc-asan, I just say that this is the simplest approach to get 2.5K test suite into gcc, and the only approach my team will be able to maintain.
gtest is not as portable as the rest of gcc, but neither is asan run-time library (which is more platform-specific than gtest). On Mon, Nov 12, 2012 at 10:08 AM, Andrew Pinski <pins...@gmail.com> wrote: > On Mon, Nov 12, 2012 at 10:05 AM, Jakub Jelinek <ja...@redhat.com> wrote: >> On Mon, Nov 12, 2012 at 09:32:04AM -0800, Wei Mi wrote: >>> Using setjmp/longjmp to do multiple tests in a single testfile, the >>> test statements in the front could affect the tests in the back. gtest >>> will fork a new process for every test statement. The forked process >>> will do only one test and skip all the other test statements. That is >>> to say, multiple test statements in the same testfile are guaranteed >>> to be independent from each other in gtest. If we use setjmp/longjmp >>> pattern to do the test, existing testsuite may need to be rewritten if >>> their test statements could affect each other. >> >> So you can either run the program multiple times from within dejagnu, or >> fork inside of the macros. In any case, adding > 5MB of gtest just for that >> single test or two is IMHO really too much, and similarly adding gtest >> as another requirement to build gcc. Does gtest support all the targets >> that gcc does btw? > > Also does gtest support cross testing; that is testing over rsh/ssh > and testing via a simulator? I see no reason why gtest will not work via ssh or in simulator. --kcc We should require that as a requirement > also when it comes to testing infrastructures. > > Thanks, > Andrew Pinski > >> >> Jakub
