On Oct 29, 2012, Jakub Jelinek <ja...@redhat.com> wrote:

>       PR debug/54402
>       * var-tracking.c (fp_setter): Return false if there is REG_CFA_RESTORE
>       hfp note.
>       (vt_initialize): Look for fp_setter in any bb, not just successor of
>       entry bb.

This looks reasonable, except that...

> --- gcc/var-tracking.c.jj     2012-10-29 12:16:23.000000000 +0100
> +++ gcc/var-tracking.c        2012-10-29 17:58:06.629025339 +0100
> @@ -9535,24 +9535,33 @@ vt_add_function_parameters (void)
>  static bool
>  fp_setter (rtx insn)
>  {
> -  rtx pat = PATTERN (insn);
> +  rtx pat = PATTERN (insn), expr;
>    if (RTX_FRAME_RELATED_P (insn))
>      {
> -      rtx expr = find_reg_note (insn, REG_FRAME_RELATED_EXPR, NULL_RTX);
> +      expr = find_reg_note (insn, REG_FRAME_RELATED_EXPR, NULL_RTX);
>        if (expr)
>       pat = XEXP (expr, 0);

... I don't get why you moved expr out of the only block in which it's
used.  Ok with or without this change.  Thanks,

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer

Reply via email to