On Tue, Oct 30, 2012 at 9:23 PM, Peter Bergner <berg...@vnet.ibm.com> wrote: > On Tue, 2012-10-30 at 20:37 +0100, Jakub Jelinek wrote: >> On Tue, Oct 30, 2012 at 02:03:44PM -0500, Peter Bergner wrote: >> > Ok, then I'll bootstrap and regtest your suggested change while we >> > wait for richi to comment. I'm fine with whatever you and richi >> > decide is best. The ObjC guys should probably test it though too. >> > >> > I assume you think we should change the current trunk code as well? >> >> Well, I haven't looked at the ObjC failures (guess they are darwin only >> anyway), so have no idea whether those set section name or not. >> So, if my proposed test instead of the trunk one doesn't work for darwin, >> perhaps it could be DECL_PRESERVED_P (decl) || (DECL_SECTION_NAME (decl) && >> !...). I think DECL_USER_ALIGN test is undesirable for that though, it is >> just fine to increase alignment of anything, after all, it is still aligned >> properly then. > > I can confirm it bootstraps and regtests without any errors...and it > fixes my problem.
I'm fine with that, but please give it some time on trunk before backporting it. Thanks, Richard. > Peter > > >
