On Thu, Oct 25, 2012 at 11:11 AM, Tom Tromey <tro...@redhat.com> wrote: >>>>>> "Dehao" == Dehao Chen <de...@google.com> writes: > > Dehao> This patch fixes debug info for expr and jump stmt. > Dehao> Bootstrapped and passed gcc regression tests. > Dehao> Is it okay for trunk? > > I wonder whether this affects the gdb test suite results.
My guess is this patch will fix several regressions there. > > I'm not trying to pick on you specifically, but there's been a few > debuginfo regressions lately that would have been caught by running the > gdb test suite against the compiler patch. > > We do catch these in gdb, but it is a pain for us to track down each one > and file it in gcc bugzilla. It would be more efficient for gcc patch > authors to do this, at least in the "obvious" case where someone is > working on a patch intended to affect debuginfo. Yes, I should have run gdb tests before. I'll run gdb tests and try to fix the regressions that are triggered by the block_location change. Thanks, Dehao > > thanks, > Tom
