On Mon, 15 Oct 2012, Gary Funck wrote: > Attached, patch 02 of 16. > > This patch set lists the small set of changes required > in the C++ and Objective C front-end to accommodate > changes needed for UPC. > > gcc/c/c-decl.c is also included here, to illustrate > both the UPC front-end changes and to motivate the introduction of > c_build_qualified_type_1() which accepts an additional argument > which is the "layout qualifier" (blocking factor) that is unique to UPC.
Please go back to my previous comments, then post a full patch series *once those issues are addressed*. Each submission needs ChangeLog entries and more detailed descriptions / rationale. For example, explain why a lang hook change is made in c-objc-common.h. Make sure that you consistently use error_at, not error, for new diagnostics, or explain in your rationale why a location isn't readily available. Make sure that source lines do not go over 80 columns. There are at least some other coding standards issues; some visible at a glance are the comment /* for static declarations of shared arrays */ (start with a capital letter, end with '.', actually say what the semantics of this variable's value are if it needs a comment) and a missing space in TREE_CODE(decl). Avoid any diff lines that are solely changing trailing whitespace (you have at least once diff hunk in c-decl.c that appears to do nothing but add such whitespace). Some indentation also looks suspicious - look at the @@ -8859,6 +9048,23 @@ declspecs_add_qual hunk, for example, where inconsistent indentation reveals that you are indenting with spaces in some places, except for one line using a TAB (all new lines should be indented with TABs for every 8 spaces). -- Joseph S. Myers jos...@codesourcery.com
