On Oct 4, 2012, Jakub Jelinek <ja...@redhat.com> wrote: > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
This is ok, except for one nit. > 2012-10-04 Jakub Jelinek <ja...@redhat.com> > PR debug/54796 > * rtl.h: Document jump flag on VALUE. > * cselib.h (cselib_set_value_sp_based, > cselib_sp_based_value_p): New prototypes. > * alias.c (find_base_term): For cselib_sp_based_value_p > return static_reg_base_value[STACK_POINTER_REGNUM]. > * cselib.c (SP_BASED_VALUE_P): Define. > (cselib_set_value_sp_based, cselib_sp_based_value_p): New functions. > * var-tracking.c (add_stores): Call cselib_set_value_sp_based > for not yet preserved VALUEs of sp on sp assignments if > hard_frame_pointer_adjustment != -1. > (vt_initialize): When setting hard_frame_pointer_adjustment, > disassociate sp from its previous value and call > cselib_set_value_sp_based on a new VALUE created for sp. > * gcc.dg/guality/pr54796.c: New test. > +/* Test whether a value is preserved. */ > + > +bool > +cselib_sp_based_value_p (cselib_val *v) The function comment needs rewriting after the cut&paste. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer
