On Thu, 11 Oct 2012, Rainer Orth wrote:
> Ok, here's the merged patch, tested on i386-pc-solaris2.10.  Ok for
> mainline?

Cool, thank you!


Just a small note, in the following

  +#ifdef __FreeBSD__
  +# define DEFAULT_PROCESS_FILENAME "/proc/curproc/file"
  +#elif defined(HAVE_GETEXECNAME)
  +# define DEFAULT_PROCESS_FILENAME getexecname ()
  +#else
  +# define DEFAULT_PROCESS_FILENAME "/proc/self/exe"
  +#endif

would it make sense to have the feature test (HAVE_GETEXECNAME) before
the OS test (__FreeBSD__), so that when/if the OS implements the feature
in newer versions that takes precedence?

Gerald

Reply via email to