On Wed, Jul 29, 2026 at 4:21 PM Uros Bizjak <[email protected]> wrote: > > On Wed, Jul 29, 2026 at 9:11 AM H.J. Lu <[email protected]> wrote: > > > > On Wed, Jul 29, 2026 at 2:57 PM Richard Biener > > <[email protected]> wrote: > > > > > > On Tue, Jul 28, 2026 at 8:25 PM Uros Bizjak <[email protected]> wrote: > > > > > > > > On Tue, Jul 28, 2026 at 5:28 PM Kumar, Venkataramanan > > > > <[email protected]> wrote: > > > > > > > > > > AMD General > > > > > > > > > > Hi Uros/HJ, > > > > > > > > > > > -----Original Message----- > > > > > > From: Uros Bizjak <[email protected]> > > > > > > Sent: Tuesday, July 28, 2026 4:58 PM > > > > > > To: Roy, Reshma <[email protected]> > > > > > > Cc: [email protected]; [email protected]; Kumar, > > > > > > Venkataramanan > > > > > > <[email protected]>; Aloor, Raghesh > > > > > > <[email protected]> > > > > > > Subject: Re: [PATCH v2] x86_cse: Check if DRAP is live with > > > > > > DF_LR_IN. > > > > > > > > > > > > Caution: This message originated from an External Source. Use > > > > > > proper caution > > > > > > when opening attachments, clicking links, or responding. > > > > > > > > > > > > > > > > > > On Tue, Jul 28, 2026 at 1:26 PM <[email protected]> wrote: > > > > > > > > > > > > > > From: Reshma Roy <[email protected]> > > > > > > > > > > > > > > The DRAP register has no reaching definition on function entry, > > > > > > > so it > > > > > > > never shows up in DF_LIVE_IN. When collecting the live > > > > > > > caller-saved > > > > > > > registers, additionally set DRAP's bit whenever it is live-in per > > > > > > > DF_LR_IN, so the hoisted TLS call is kept after the DRAP save. > > > > > > > > > > > > > > PR target/126382 > > > > > > > > > > > > > > gcc/ChangeLog: > > > > > > > > > > > > > > * config/i386/i386-features.cc (ix86_emit_tls_call): > > > > > > > Additional > > > > > > > check to see if DRAP register is live in basic block > > > > > > > with DF_LR_IN. > > > > > > > > > > > > > > gcc/testsuite/ChangeLog: > > > > > > > > > > > > > > * gcc.target/i386/pr126382.c: New test. > > > > > > > > > > > > OK. > > > > > > > > > > Is it Ok to backport this to GCC 16 ?? > > > > > > > > OK, but if there is no hurry, please wait for some time (a week or > > > > two) for the patch to soak in the mainline before backporting. We > > > > expect that fuzzers will find any issues during this time. > > > > > > I'll note that this Friday we plan to do GCC 16.2 RC > > > > I think this patch should be included in GCC 16.2. > > Fine by me, but please check if RM approval is needed at this stage. > > Uros.
Richard said: https://gcc.gnu.org/pipermail/gcc-patches/2026-July/725640.html RM approval is currently not needed for regression fixes (or wrong-code/ice-on-valid or other serious issues). I am backporting it to GCC 16. -- H.J.
