Thanks for comments. > -----Original Message----- > From: Steven Bosscher [mailto:[email protected]] > Sent: Friday, September 28, 2012 4:29 PM > To: Bin Cheng > Cc: [email protected]; Eric Botcazou; Richard Sandiford; > [email protected] > Subject: Re: [PATCH RFA] Implement register pressure directed hoist pass > > On Fri, Sep 28, 2012 at 9:18 AM, Bin Cheng <[email protected]> wrote: > > (get_regno_pressure_class, get_pressure_class_and_nregs) > > Broken long lines in a ChangeLog entry end with a ",".
Did the mail-client wrap this line? I found no line exceeding 80 characters, or I missed something? > > > > (change_pressure, mark_regno_live, mark_regno_death, mark_reg_death) > > (mark_reg_store, mark_reg_clobber, calculate_bb_reg_pressure) > > Please use the DF caches instead of note_stores, note_uses, etc. These register pressure calculation codes are copied from loop-invariant.c. I was thinking: Should we just export these interfaces from loop-invariant.c, or copy it as in this patch. Maybe we can abstract these function/data-structure into a common file? I would like to hear your comments. If we decide to keep these codes in gcse.c, I will make the change using DF caches according to your comments. Moreover, it seems I still have to iterate REG_NOTES to find REG_UNUSED/REG_DEAD information, or I can get them from DF caches too? Thanks. > > > > (free_bb_data): New. > > Please use alloc_aux_for_blocks (in calculate_bb_reg_pressure) and > free_aux_for_block. Yes.
