On Tue, Sep 25, 2012 at 07:21:04PM -0300, Alexandre Oliva wrote:
> On Sep 25, 2012, Jakub Jelinek <ja...@redhat.com> wrote:
>
> > (the other alternative would be to use mode in the hash function etc.,
> > but if usually the same pseudo has the same mode everywhere, then the above
> > should be good enough).
>
> AFAIK each pseudo is referenced everywhere using the same RTX; if so, it
> follows that it has the same mode in all uses.
Ok, leave the mode check out then. But still checking the result of the
function is IMHO desirable.
> > I believe the coding conventions ask to put the inlines outside of the
> > class body, see e.g. coverage.c.
>
> I wasn't sure about one-liners; hash-table.h itself has inline
> one-liners, one of which I used as the basis for the descriptor. That
> said, the braces were not in separate lines.
Seems the C++ coding conventions are unfinished and vague and the codebase
is growing different styles in different spots :(.
> I'm going on a trip tomorrow morning, and I'll only return on Friday
> evening. I'll have a look at the C++ coding conventions and the other
> issues you brought up when I return. However, if you'd rather have the
> fix in before that, I won't mind if you pick it up from where I left.
I can wait, after all the related msg00711.html patch hasn't been reviewed
yet anyway.
Jakub
