On Wed, Sep 26, 2012 at 12:46 PM, Dehao Chen <de...@google.com> wrote:
> This patch fixes some small nits.
>
> Bootstrapped and passed gcc regression tests.
>
> Is it ok for trunk?
>
> Thanks,
> Dehao
>
> gcc/ChangeLog:
>
> 2012-09-26 Dehao Chen <de...@google.com>
>
> * tree-ssa-live.c (clear_unused_block_pointer): Fix two small nits.
I know it's tedious, but this is meaningless to a future reader.
Better to say what you changed. E.g.,
* tree-ssa-live.c (clear_unused_block_pointer): Use explicit
(void) for parameters. Don't use LOCATION_BLOCK if it is NULL.
> static void
> -clear_unused_block_pointer ()
> +clear_unused_block_pointer (void)
I don't think we need to say (void) any more now that we use C++. But
I guess it does no harm.
> FOR_EACH_EDGE (e, ei, bb->succs)
> - if (e->goto_locus)
> + if (LOCATION_BLOCK (e->goto_locus))
> TREE_USED (LOCATION_BLOCK (e->goto_locus)) = true;
Please write if (LOCATION_BLOCK (e->goto_locus) != NULL).
This is OK with those changes.
Thanks.
Ian
