Am Fr., 20. Feb. 2026 um 01:32 Uhr schrieb Andrew Pinski
<[email protected]>:
>
> On Thu, Feb 19, 2026 at 2:13 PM oltolm <[email protected]> wrote:
> >
> > In Clang the argument is const, therefore you need to use
> > const_cast<void*> to call _m_prefetchw.
>
> https://learn.microsoft.com/en-us/cpp/intrinsics/x86-intrinsics-list?view=msvc-170
> Hmm, GCC matches Microsoft's documentation but does not match
> Microsoft's definition.
> See https://github.com/llvm/llvm-project/issues/48468 where LLVM
> changed it to `volatile const` rather than just const.
> So you patch should be changing it to `volatile const void*`.
> Also even though this patch is small, it would be better if you either
> have a copyright assignment or agree with a DCO.
> See https://gcc.gnu.org/contribute.html#legal .
>
> Also next time please add a changelog to your commit message as
> mentioned on https://gcc.gnu.org/contribute.html.
> A testcase or two would be a good idea or maybe there is a testcase
> that needed to be changed.
> And also mention how you tested this patch.

I posted version 2 of the patch here:
https://gcc.gnu.org/pipermail/gcc-patches/2026-May/715922.html

I have manually tested the patch by compiling a program. I don't know
how to write a testcase for this patch.

Best regards
Oleg Tolmatcev

Reply via email to