Re: [PATCH] PR other/54411: libiberty: objalloc_alloc integer overflows (CVE-2012-3509)

[Florian Weimer]

On 09/17/2012 05:59 PM, Ian Lance Taylor wrote:

Fair enough.  I've added a wraparound check to the macro.  Okay for trunk?

  {
+  unsigned long len = original_len;
    /* We avoid confusion from zero sized objects by always allocating
       at least 1 byte.  */

Please add a blank line after the variable declaration.

-     (__len <= __o->current_space                                        \
+     (__len && __len <= __o->current_space                               \

Please write __len != 0 or len > 0.

This is OK with those changes.

Thanks, committed with these changes.

--
Florian Weimer / Red Hat Product Security Team