On Fri, Sep 14, 2012 at 12:49 AM, Tom Tromey <tro...@redhat.com> wrote:
>>>>>> "Dehao" == Dehao Chen <de...@google.com> writes:
>
> Dehao> + static htab_t location_adhoc_data_htab;
> Dehao> + static source_location curr_adhoc_loc;
> Dehao> + static struct location_adhoc_data *location_adhoc_data;
> Dehao> + static unsigned int allocated_location_adhoc_data;
>
> libcpp was written to allow multiple preprocessor objects to be created
> and used in one process.  I think introducing globals like this breaks
> this part of the design.  It seems to me they should instead be fields
> of cpp_reader or line_maps.

Okay. I've moved these into line_maps. Will send out the whole patch soon...

Thanks,
Dehao

>
> Tom

Reply via email to