On Thu, Sep 13, 2012 at 07:42:17PM +0200, Uros Bizjak wrote: > Can we introduce additional "*fmai_fmadd_<mode>_1" pattern (and > others) that would cover missing 231 alternative?
Sure. Will cook up a patch soon. > > 2012-09-13 Jakub Jelinek <ja...@redhat.com> > > > > PR target/54564 > > * config/i386/sse.md (fmai_vmfmadd_<mode>): Use (match_dup 1) > > instead of (match_dup 0) as second argument to vec_merge. > > (*fmai_fmadd_<mode>, *fmai_fmsub_<mode>): Likewise. > > Remove third alternative. > > (*fmai_fnmadd_<mode>, *fmai_fnmsub_<mode>): Likewise. Negate > > operand 2 instead of operand 1, but put it as first argument > > of fma. > > > > * config/i386/fmaintrin.h (_mm_fnmadd_sd, _mm_fnmadd_ss, > > _mm_fnmsub_sd, _mm_fnmsub_ss): Negate the second argument instead > > of the first. > > OK, but header change should be also reviewed by H.J. H.J., are you ok with this? Jakub