On Wed, Sep 12, 2012 at 4:54 PM, Aaron Gray <aaronngray.li...@gmail.com> wrote: > On 11 September 2012 23:45, Gabriel Dos Reis > <g...@integrable-solutions.net> wrote: >> On Tue, Sep 11, 2012 at 3:41 PM, Diego Novillo <dnovi...@google.com> wrote: >> >>>> @@ -778,6 +791,7 @@ type (options_p *optsp, bool nested) >>>> return resolve_typedef (s, &lexer_line); >>>> >>>> case STRUCT: >>>> + case CLASS: >>> >>> >>> I think that as far as gengtype is concerned, 'struct' and 'class' should be >>> exactly the same thing. So, all the handling for 'CLASS' you added should >>> not be needed. >> >> >> 100% agreed. > > The reason I included a CLASS type distinct from STRUCT was for > reporting debugging information when I get to that stage.
In general, patches are easier to assess when they are self-contained (e.g. each change is justified by the purpose of the patch.) My recommendation would be for your patches to focus on one topic at a time. -- Gaby
