On Tue, Sep 11, 2012 at 4:36 PM, Lawrence Crowl <cr...@googlers.com> wrote: > On 9/11/12, Ian Lance Taylor <i...@google.com> wrote: >> This patch is the interface to and configury of libbacktrace. >> I've separated these out as the parts of libbacktrace that >> require the most review. The interface to libbacktrace is in >> the file backtrace.h. This is what callers will use. The file >> backtrace-supported.h is also available so that programs can see >> whether calling the backtrace library will work at all. > > The interface relies on global data in the library. Wouldn't it > be better to expose the state as an additional parameter to enable > concurrent access by different threads? That parameter could then > be modeled as 'this' parameter, addressing Gaby's suggesting.
I went ahead and added a state parameter to the interface. I've attached the updated patch. Ian
foo1.patch
Description: Binary data
