Re: [PATCH] contrib: Skip libstdc++ files in check_GNU_style.py

[Christophe Lyon]

On Thu, 4 Dec 2025 at 11:55, Jonathan Wakely <jwak...@redhat.com> wrote:
>
> The libstdc++ style is different from the rest of GCC, so do not apply
> the checks to libstdc++ files in a patch.
>
> contrib/ChangeLog:
>
>         * check_GNU_style_lib.py (check_GNU_style_file): Do not check
>         libstdc++ files.
> ---
>
> This is needed because the "sanity check" action on the Forge fails for
> libstdc++ patches.

LGTM FWIW, simpler than hacking something similar in the Yaml file ;-)

Thanks,

Christophe

>
> OK for trunk?
>
>  contrib/check_GNU_style_lib.py | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/contrib/check_GNU_style_lib.py b/contrib/check_GNU_style_lib.py
> index faf30c4d9a2e..fccb3d656918 100755
> --- a/contrib/check_GNU_style_lib.py
> +++ b/contrib/check_GNU_style_lib.py
> @@ -285,6 +285,9 @@ def check_GNU_style_file(file, format):
>          # Skip testsuite files
>          if 'testsuite' in t or t.endswith('.py'):
>              continue
> +        # Libstdc++ does not use GNU style
> +        if t.startswith('libstdc++-v3/'):
> +            continue
>
>          for hunk in pfile:
>              delta = 0
> --
> 2.52.0
>