On 11/10/25 4:55 PM, Lewis Hyatt wrote:
Ping please? It would be great to tie up this loose end. Thanks!
https://gcc.gnu.org/pipermail/gcc-patches/2025-August/692261.html
-Lewis
On Sun, Oct 12, 2025 at 9:44 AM Lewis Hyatt <[email protected]> wrote:
Hello-
https://gcc.gnu.org/pipermail/gcc-patches/2025-August/692261.html
Can I ping this one please? It fixes a small glitch with the
transition to 64-bit location_t. I would like to have it for 16 and
also 15 backport. Thanks!
-Lewis
On Sat, Aug 9, 2025 at 1:36 PM Lewis Hyatt <[email protected]> wrote:
Hello-
This fixes an ICE with -fdump-internal-locations that started with 64-bit
location_t support. That option is only really there for debugging, I
haven't seen any PR about it. But I would like also to backport it to 15.3
please. bootstrap + regtest all languages on x64-64 Linux looks good. OK?
Thanks!
-Lewis
-- >8 --
When adding support for 64-bit location_t in GCC 15, I missed a couple
changes needed for the internal debugging tool -fdump-internal-locations to
work properly. This would previously ICE on a location_t large enough to
overflow a signed 32-bit int.
gcc/ChangeLog:
* diagnostics/context.cc (num_digits): Change argument type from
`int' to `uint64_t'.
(test_num_digits): Add test for 64-bit argument.
* diagnostic.h (num_digits): Adjust prototype.
* input.cc (write_digit): Accept argument in range [0,10) instead of
an arbitrary int.
(write_digit_row): Adjust to change in write_digit().
gcc/testsuite/ChangeLog:
* gcc.dg/plugin/location-overflow-test-3.c: New test.
* gcc.dg/plugin/plugin.exp: Add the new test.
OK. Sorry this fell through the cracks.
jeff
