Hi Harald! On Thu, 6 Nov 2025 21:15:50 +0100 Harald Anlauf <[email protected]> wrote:
> Hi Christopher! > > Am 05.11.25 um 22:30 schrieb Christopher Albert: > > On Wed, 5 Nov 2025 13:12:04 -0800 > > Steve Kargl <[email protected]> wrote: > > > >> On Sun, Nov 02, 2025 at 02:20:59PM +0100, Christopher Albert wrote: > >>> Rebased again on trunk with small corrections, correct text format > >>> directly pasted in the e-mail and without attachments (sorry for > >>> the mess before, I'm new to to the GCC patch workflow). Tested on > >>> x86_64 by Stefan Kargl on FreeBSD and by myself on Linux. See > >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=121628 for details. > >>> > >> > >> Can you attach the diff file? When I save your email > >> to a text and open it in nedit, there as numerous non-ASCII > >> characters embedded in the diff. Specifically, I see > >> Unicode character (U+00C2), and in hexdump the hex digits > >> are c2a0 where I expect one or more spaces. > >> > > > > Sorry, some trouble with email client. I try claws-mail now and > > attach the diff file. > > I could not find out if you have a copyright assignment on file. > Since you are not listed in MAINTAINERS, I assume this is not the > case. In this situation I believe you need to sign-off your > contribution, see: > > https://gcc.gnu.org/dco.html > > *** > > I just applied your patch here, and get a couple of complaints about > white-space issues. Jerry might be able to remedy them. > > Regarding coding style: I would prefer if you stick to the GNU style > and tried to keep lines below the 80 characters mark. But this is > not a showstopper. Sorry that this has slipped formatting, I fix it right away. > > I wonder if the change you applied to conv_intrinsic_atomic_op is of > the same origin as what Andre mentioned in > > https://gcc.gnu.org/pipermail/fortran/2025-October/062998.html > > I didn't have time to check, but your comment lead me to that > assumption. Still we can keep your version. This is fine, I can easily switch to using gfc_trans_force_lval > > diff --git a/libgfortran/libgfortran.h b/libgfortran/libgfortran.h > index 25c3cb6641c..71ec640b335 100644 > --- a/libgfortran/libgfortran.h > +++ b/libgfortran/libgfortran.h > @@ -914,6 +914,14 @@ internal_proto(xcalloc); > extern void *xrealloc (void *, size_t); > internal_proto(xrealloc); > > +/* deep_copy.c - Runtime helper for recursive allocatable array > components */ > + > +struct CFI_cdesc_t; > ^^^^^^^^^^^^^^^^^^^ > > Is that a left-over from previous work? It is not needed and > should be removed. Indeed, will remove. > > Otherwise I am fine so far with it, and it appears that Steve > and Jerry have tested it already. > > Thanks for the patch! > > Harald > Thanks for taking the time to review and the suggestions! Best Chris
