On Wed, 29 Oct 2025, Lewis Hyatt wrote: > Thanks very much for reviewing it. That's correct, it is currently > only used for PCH. I could add a comment to this effect if you think > it's helpful? Like this perhaps: > > diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h > index 799a58036d5..2cd54d0770e 100644 > --- a/libcpp/include/line-map.h > +++ b/libcpp/include/line-map.h > @@ -879,7 +879,9 @@ public: > location_t builtin_location; > > /* The special location value to be used for tokens originating on the > - command line. */ > + command line. This is currently only needed by the C-family front ends > + for PCH support; if it would be used for another purpose in the future, > + then other libcpp-using front ends may need to set it as well. */ > location_t cmdline_location;
Yes, I think this comment is useful. -- Joseph S. Myers [email protected]
