On Wed, Oct 29, 2025 at 7:21 PM Andrew Pinski <[email protected]> wrote: > > This clarifies the comment about the sizes difference > being about bytes (or units). > As shown by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=122478#c3, > the implicit bytes/units was not always being thought of.
Hmm, I think 'size' is the correct term. Maybe instead add a 'Note, the types may still have different precision'.? > gcc/ChangeLog: > > * tree.def (VIEW_CONVERT_EXPR): Clarify what size is being > talked about. > > Signed-off-by: Andrew Pinski <[email protected]> > --- > gcc/tree.def | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/tree.def b/gcc/tree.def > index 0cd39f95b0b..6d2255eca11 100644 > --- a/gcc/tree.def > +++ b/gcc/tree.def > @@ -474,7 +474,7 @@ DEFTREECODE (IMAGPART_EXPR, "imagpart_expr", > tcc_reference, 1) > This corresponds to an "Unchecked Conversion" in Ada and roughly to > the idiom *(type2 *)&X in C. The only operand is the value to be > viewed as being of another type. It is undefined if the type of the > - input and of the expression have different sizes. > + input and of the expression have different (byte/unit) sizes. > > This code may also be used within the LHS of a MODIFY_EXPR, in which > case no actual data motion may occur. TREE_ADDRESSABLE will be set in > -- > 2.43.0 >
