Hi Gerald, On Sun, 26 Aug 2012 23:28:49 +0200 (CEST) Gerald Pfeifer <ger...@pfeifer.com> wrote:
> I have tested this patch on i386-unknown-freebsd10.0 and volunteer > to create a ChangeLog and apply if approved. Thanks for taking care of this, I thought this patch had been completely forgotten :) FWIW, the git commit message was supposed to be the ChangeLog entry (imho it is rather pointless to include it in the patch since it will most likely conflict when/if it gets applied) > > Any reviewer? > > On Tue, 8 May 2012, Alexis Ballier wrote: > > For the record, there's a similar logic in FreeBSD's gcc: > > http://svnweb.freebsd.org/base/head/contrib/gcc/config/freebsd-spec.h?revision=200038&view=markup > > Thanks for the patch, Alexis. One question: why do we have the same > in freebsd-spec.h and i386/freebsd.h. Isn't there a way to simplify > this? Like omitting this from i386/freebsd.h at all? To be honest, I don't know why we have the same in these two headers and wondered the same. I suppose it is possible to simply remove it from i386/freebsd.h but I didn't test this since I didn't want to mix a bugfix for PIE and cleanup of the code within the same patch. Regards, Alexis. [...]
