Hi Alfie,
On 10/9/25 13:52, Alfie Richards wrote:
The 10/09/2025 10:32, Wilco Dijkstra wrote:
Hi Alfie,
Hi Wilco, thank you for the review
+/* TODO: These FMV features are not yet supported in GCC. */
+// int fn [[gnu::target_version("dit")]] (int) { return
1; }
+// int fn [[gnu::target_version("dpb")]] (int) { return
1; }
+// int fn [[gnu::target_version("dpb2")]] (int) { return
1; }
Can you fix these (and later ones)? I believe they are all supported since
GCC15.
I don't think they are. They are supported features, but we haven't added the
fmv support yet. (see https://godbolt.org/z/dPxjjfo1T)
I plan to add support soon.
Ah, I see they are supported by the runtime but not yet in GCC...
What I could do is break it into many smalled statements, so instead of a check
for
fn\.default/\[0-9\]+\\nfn\._Mrng/\[0-9\]+\\nfn\._Mflagm/\[0-9\]+\\nfn\._Mflagm2/\[0-9\]+\\nfn\._Mlse/\[0-9\]+\\n
...
We have checks for:
fn\.default/\[0-9\]+\\nfn\._Mrng/\[0-9\]+\\n
fn\._Mrng/\[0-9\]+\\nfn\._Mflagm/\[0-9\]+\\n
fn\._Mflagm/\[0-9\]+\\nfn\._Mflagm2/\[0-9\]+\\n
individually.
This would achieve the same thing and be marginally better?
Yes that seems more reasonable. I think you could have 3 per line so
that you effectively halve the number of lines.
Cheers,
Wilco
