On 09/10/2025 16:05, Robin Dapp wrote:
Ugh, I missed two "s/also/not/"... I thought I checked that. And of course it
had to be the top one, somehow. I can make that change.
I just read up to the first ;) Looks like the last one is also missing the
not.
Are the other ones OK?
IMHO yes but I cannot approve. Maybe you also want to make explicit that we
just perform costing (and record the cost in COST_VEC) if COST_VEC is passed?
Looks like cost_vec isn't even documented so far.
How is this?
If COST_VEC is passed, calculate costs but don't change anything,
otherwise, vectorize STMT_INFO: create a vectorized stmt to replace
it, and insert it at GSI.
I wanted to remove the lies, but I don't claim to understand the code
well enough to fully document it. There are lots of other examples of
undocumented parameters (e.g. VINFO and SLP_NODE, on vectorizable_*, but
I'm pretty sure those are just the context for STMT_INFO).
Andrew
