On 15/10/2025 14:18, Tobias Burnus wrote:
The patch updates https://gcc.gnu.org/onlinedocs/libgomp/OpenMP-Context- Selectors.htmlto clarify the behavior of 'isa("gfx9-generic")' vs. 'isa("gfx900")'.(The documentation update also applies to Nvptx.) Additionally, for AMD GCN, only: - It enables the ISA context selector for generic ISAs names - As copy-n-paste bug, gfx942 and gfx950 missed the link to their generic name (relevant for the ABI/ISA check in libgomp's plugin-gcn) - I updated the context selector check to handle generic names: testsuite/libgomp.c/declare-variant-4*.{h,cc} For the latter, expected result is: - PASS for scan-amdgcn-amdhsa-offload-tree-dump - some PASS, some FAIL for '(test for excess errors)' depending on the configured multilib; if failing, the message contains "ld: error: unable to find library -lgomp". (The latter is consistent with previous results, except that some more tests will fail, unless you have that multilib.) OK for mainline?
The GCN bits look OK, although it would be nice if unsupported tests didn't FAIL.
Andrew
