>>>>> "David" == David Faust <[email protected]> writes:

I was comparing the GCC and GDB copies of dwarf2.def today and ran
across this patch.

David> DW_AT_GNU_annotation is a new attribute extension used to refer to these
David> new annotation DIEs.  If non-null in any given declaration or type DIE,
David> it is a reference to a DW_TAG_GNU_annotation DIE holding an annotation
David> for that declaration or type.  In addition, the DW_TAG_GNU_annotation
David> DIEs may also have a non-null DW_AT_GNU_annotation, referring to another
David> annotation DIE.

David> +DW_TAG (DW_TAG_GNU_annotation, 0x6001)

It seems strange that this was given this value and not something closer
to the other GNU extension tag values.

However, that's a minor thing.  The real reason I am writing is that I
think all DWARF extensions should come with documentation.  In the old
days this wasn't done and it's proved to be a pain for gdb.

The normal thing to do is write a page on the GCC wiki that explains the
extension, then add a link from the .def file to that page.

Furthermore I think requiring documentation for GNU DWARF extensions
should be part of the dwarf2.{def,h} review checklist.

thanks,
Tom

Reply via email to