The following disables the use of rotate patterns with reductions
since it breaks then single rotate SSA use-def chain constraints.

Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.

        PR tree-optimization/122023
        * tree-vect-patterns.cc (vect_recog_rotate_pattern): Disable
        for rotates.

        * gcc.dg/vect/pr122023.c: New testcase.
---
 gcc/testsuite/gcc.dg/vect/pr122023.c | 17 +++++++++++++++++
 gcc/tree-vect-patterns.cc            |  4 ++++
 2 files changed, 21 insertions(+)
 create mode 100644 gcc/testsuite/gcc.dg/vect/pr122023.c

diff --git a/gcc/testsuite/gcc.dg/vect/pr122023.c 
b/gcc/testsuite/gcc.dg/vect/pr122023.c
new file mode 100644
index 00000000000..7555907730f
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr122023.c
@@ -0,0 +1,17 @@
+/* { dg-do compile } */
+/* { dg-require-effective-target int32plus } */
+
+unsigned int gvar1;
+int gvar2;
+void f ()
+{
+  unsigned int temp1;
+  while (gvar1--)
+    {
+      temp1 = gvar2;
+      gvar2 >>= 1;
+      gvar2 &= 2147483647;
+      temp1 <<= 31;
+      gvar2 |= temp1;
+    }
+}
diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc
index 70bf768d339..782327235db 100644
--- a/gcc/tree-vect-patterns.cc
+++ b/gcc/tree-vect-patterns.cc
@@ -3882,6 +3882,10 @@ vect_recog_rotate_pattern (vec_info *vinfo,
        goto use_rotate;
     }
 
+  /* We may not use a reduction operand twice.  */
+  if (vect_is_reduction (stmt_vinfo))
+    return NULL;
+
   tree utype = unsigned_type_for (type);
   tree uvectype = get_vectype_for_scalar_type (vinfo, utype);
   if (!uvectype)
-- 
2.43.0

Reply via email to