On Mon, Aug 25, 2025 at 9:51 PM Sam James <s...@gentoo.org> wrote:
>
> "H.J. Lu" <hjl.to...@gmail.com> writes:
>
> > PR tree-optimization/121656
> > * gcc.dg/pr121656.c: New file.
> >
> > Signed-off-by: H.J. Lu <hjl.to...@gmail.com>
> > ---
> > gcc/testsuite/gcc.dg/pr121656.c | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> > create mode 100644 gcc/testsuite/gcc.dg/pr121656.c
> >
> > diff --git a/gcc/testsuite/gcc.dg/pr121656.c
> > b/gcc/testsuite/gcc.dg/pr121656.c
> > new file mode 100644
> > index 00000000000..00b89418a31
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.dg/pr121656.c
> > @@ -0,0 +1,21 @@
> > +/* { dg-do run } */
> > +/* { dg-options "-O1" } */
> > +
> > +__attribute__ ((weak))
>
> Needs dg-require-weak, I think.
>
> (Or just noipa instead if that works).
noipa is definitely better. Also maybe also place it into
`gcc.dg/torture` and remove the dg-options.
And maybe even a quick comment in the testcase about what it is
testing. So someone does not have to dig through bug reports to
understand it.
Thanks,
Andrew Pinski
