On Thu, 17 Jul 2025, John Ericson wrote: > This current patch doesn't go as far as removing all such subdir logic > from the libgcc build --- rather, as an intermediate goal, it moves it > out of the Makefiles and into the configure script. That is to say, in > the makefiles there is no longer any more libsubdir, and everything just > uses libdir/includedir, while in the configure script, the original > libdir is assigned to a temporary (non-substituted) org_libdir variable, > and then libdir and includedir are redefined to be the proper subdirs of > org_libdir.
That feels potentially confusing. The name libsubdir has a well-understood meaning in GCC; names that mean different things in different directories (host versus target, libgcc versus other target libraries) add an extra complication to reading the build system code. So I'm not convinced that using libdir and includedir for this is a good idea. (Refactoring to share more configure logic for computing the directory variants between target libraries would be a good idea, however, and "get those settings passed down from top level" is one plausible end state - sharing logic implicitly that way rather than expanding it all locally in each target library configure script, even if expanding it locally for each library is useful as an intermediate stage.) -- Joseph S. Myers josmy...@redhat.com
